Add fonts to support more different types of characters for multiple languages #29861

lucasfcosta · 2022-01-14T15:30:18Z

⚠️ Please let me know if we should backport this to 7.17.

What does this PR do?

This PR fixes #29495 by adding more fonts to support multiple different characters from multiple languages.

After upgrading the base image, even though all characters from a few languages worked fine, not all characters from all languages were being displayed.

Therefore, this PR installs the following packages within the elastic-agent and heartbeat images so that those can work fine:

fonts-arphic-ukai
fonts-arphic-uming
fonts-ipafont-mincho
fonts-ipafont-gothic
fonts-unfonts-core

Why is it important?

This is important because customer's websites use a wide variety of language and we must have an inclusive synthetics product capable of displaying a wide variety of characters in the screenshots it takes.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

I'd appreciate it if reviewers could check the following items:

Do these dependencies cover all characters we're planning on supporting?
Are there more font-packs we need? If so, which?
Does this need a backport for 7.17?

How to test this PR locally

For Heartbeat

Checkout this branch
Navigate into the heartbeat directory within x-pack
Build its image using env PLATFORMS="+all linux/amd64" mage package.

Create a file with monitors which access websites in different languages:

output.elasticsearch:
  hosts: ["http://elasticsearch:9200"]
  username: "elastic"
  password: "changeme"

heartbeat.monitors:
- type: browser
  id: korean-characters
  name: korean_characters_test
  schedule: '@every 1m'
  source:
    inline:
      script: |-
        step("first", async () => {
          await page.goto('https://www.naver.com/');
        });
- type: browser
  id: chinese-characters
  name: chinese_characters_test
  schedule: '@every 1m'
  source:
    inline:
      script: |-
        step("first", async () => {
          await page.goto('https://baike.baidu.com/');
        });
- type: browser
  id: russian-characters
  name: russian_characters_test
  schedule: '@every 1m'
  source:
    inline:
      script: |-
        step("first", async () => {
          await page.goto('https://yandex.ru/');
        });
- type: browser
  id: arabic-characters
  name: arabic_characters_test
  schedule: '@every 1m'
  source:
    inline:
      script: |-
        step("first", async () => {
          await page.goto('https://www.bbc.com/arabic');
        });

Run elastic-package stack up and then run the Heartbeat container mounting the configuration file above. That will cause the container to use the locally built image.

docker run \
  -it \
  -u 0 \
  --entrypoint=/bin/bash \
  --rm \
  --name=heartbeat \
  --user=heartbeat \
  --volume="/tmp/hb1.yml:/usr/share/heartbeat/heartbeat.yml:ro" \
  --network="elastic-package-stack_default" \
  docker.elastic.co/beats/heartbeat:8.1.0

Check the screenshot which Heartbeat is going to send for each inline monitor.

For Elastic Agent

Checkout this branch
Navigate into the elastic-agent directory within x-pack
Build its image using env PLATFORMS="+all linux/amd64" mage dev:package.
Start an Elastic Stack using elastic-package stack up using a compatible stack version
In Kibana, create browser monitors which access the following websites:
- https://www.naver.com
- https://baike.baidu.com
- https://yandex.ru/
- https://www.bbc.com/arabic
  An inline script like the one below for each of these websites should be enough:
```
step("first", async () => {
  await page.goto('https://www.naver.com/');
});
```

Run a container with the elastic-agent-complete image and change its entry-point to /bin/bash so you can go into it.

docker run \
  -it \
  --entrypoint=/bin/bash \
  --rm \
  --name=elastic-agent \
  --user=elastic-agent \
  --volume="/Users/lucasfcosta/Repositories/synthetics:/usr/share/synthetics" \
  --network="elastic-package-stack_default" \
  docker.elastic.co/beats/elastic-agent-complete:8.1.0

Enroll your agent with elastic-agent enroll --insecure --url=http://fleet-server:8220 --enrollment-token=POLICY_TOKEN_HERE. You can get the enrollment token and policy tokens in Kibana (under Fleet).
Start your agent with elastic-agent & and wait for it to send screenshots for the monitors you've set up in Kibana.

Related issues

Fixes [Heartbeat] Missing some i18n fonts in heartbeat docker image #29495

Screenshots

…iple languages [fix elastic#29495]

mergify · 2022-01-14T15:30:43Z

This pull request does not have a backport label. Could you fix it @lucasfcosta? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

andrewvc · 2022-01-14T16:43:05Z

LGTM, tested all those sites myself, they all work

elasticmachine · 2022-01-14T16:53:14Z

Pinging @elastic/uptime (Team:Uptime)

elasticmachine · 2022-01-14T19:02:21Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Reason: null
Start Time: 2022-01-28T09:09:44.611+0000
Duration: 220 min 3 sec
Commit: 668449d

Test stats 🧪

Test	Results
Failed	0
Passed	47979
Skipped	4285
Total	52264

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

vigneshshanmugam · 2022-01-14T19:54:03Z

dev-tools/packaging/templates/docker/Dockerfile.elastic-agent.tmpl

@@ -69,7 +69,12 @@ RUN apt-get update -y && \
        libcairo2\
        libasound2\
        libatspi2.0-0\
-        libxshmfence1 && \
+        libxshmfence1 \
+        fonts-arphic-ukai \


I am curios about the list we arrived at here, We don't even have the basic one fonts-liberation for the image.

Do we know if that works?

Here is the list from PW for comparison - https://github.com/microsoft/playwright/blob/5ba7903ba098586a13745e0d7ac894f1d55d47aa/packages/playwright-core/src/utils/nativeDeps.ts#L434-L470

One we use in RUM agent for puppeteer and playwright - https://github.com/elastic/apm-agent-rum-js/tree/master/.ci/docker

Here I followed an approach of testing websites and taking note of which didn't display all characters correctly. Then, I went after the packages only for those, and ran an E2E test which generated the images above. I followed this process to avoid adding too many unnecessary packages.

Wrt to fonts-liberation, it seemed to be a standard set of fonts which could just replace the default set of fonts to which it's compatible, but we already have default fonts for western characters in the base image and thus I thought we wouldn't need that. Looking into the other packages, they also seem to fall into one of two categories:

Covering standard character sets (like fonts-liberation or ttf-unifont)

Tools for managing fonts themselves (like libfontconfig)

The other fonts seemed to be the most complete and popular fonts for their character standards (fonts-arphic-ukai [for chinese characters] , fonts-ipafont-mincho [for japanese characters, fonts-ipafont-gothic being for sans-serif japanese characters], and fonts-unfonts-core for Korean characters). Those were the ones which came up when I looked for packages for each individual language.

We already had support for Arabic/Russian characters in the base image as per the initial test, so I haven't added those as the websites I visited already displayed correctly. It could be the case that there are characters outside the unicode space

Looking at Playwright's deps these are the changes I see we could make:

fonts-wqy-zenhei this seems like a more complete font set to replace the one in the package we have. However, I was just thinking about the licensing of these given that this package seems to be GPL licensed and therefore I don't know whether we could include it in the image we distribute. The Arphic Public License for the current fonts seem to only apply for modification of the fonts themselves and is incompatible with GPL and thus seems fine, but actually it would be good to review.
➡️ @andrewvc @vigneshshanmugam do we have a particular specialist in software licensing to review these?

fonts-tlwg seems to support Thai characters, so that's one I think we could add. However, it also includes GPL licensed fonts, so we must double check that.

[fonts-noto-color-emoji] for supporting Google's emoji set (which should really follow the same set as the standard, shouldn't it?)

I moved this PR to draft just so that we would make sure to review the licensing and whether we're happy with the current coverage set. I do thing we should add fonts-tlwg though, so I'll run a test for that before opening this PR for review again too.

andrewvc · 2022-01-14T21:16:27Z

/test

andrewvc

I'm LGTM but let's address @vigneshshanmugam 's comments before merging

…iple languages [fix elastic#29495]

lucasfcosta · 2022-01-19T16:45:44Z

After talking about this issue with @vigneshshanmugam, I've addressed a couple more of his points:

I double-checked that the new image has good support for default fallback fonts. I did so by accessing different websites with all requests enabled and then accessing the very same websites while disabling font requests in playwright.
Here is an example of a script I used.
```
step("cnn without fonts", async () => {
    await page.route('**/*', (route) => {
          return route.request().resourceType() === 'font'
              ? route.abort()
              : route.continue()
    });
    await page.goto('https://cnn.com');
});

step("cnn with fonts", async () => {
    await page.route('**/*', (route) => route.continue());
    await page.goto('https://cnn.com');
});
```
I also accessed https://furbo.org/stuff/systemfonts-new.html, which has default font values in CSS and loads no font files. In that website, all of the pieces of text rendered fine in the system's fallback font (although they don't have stylistic differences as we're using a fallback).

Furthermore, I also confirmed that we cannot run headful tests in the new ubuntu images because there's no X display in them (as shown in the error log below).

heartbeat@0699f71daf07:~$ synthetics /usr/share/synth-example/ --no-headless
  Failed to run the test browserType.launch: Protocol error (Browser.getVersion): Browser closed.
  ==================== Browser output: ====================
  <launching> /usr/share/heartbeat/.cache/ms-playwright/chromium-907428/chrome-linux/chrome --disable-background-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-background-pages --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose --allow-pre-commit-input --disable-hang-monitor --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-backgrounding --disable-sync --force-color-profile=srgb --metrics-recording-only --no-first-run --enable-automation --password-store=basic --use-mock-keychain --no-service-autorun --user-data-dir=/tmp/playwright_chromiumdev_profile-vWKBgW --remote-debugging-pipe --no-sandbox --no-startup-window
  <launched> pid=244
  [pid=244][err] [244:244:0119/160156.284241:ERROR:browser_main_loop.cc(1400)] Unable to open X display.
  =========================== logs ===========================
  <launching> /usr/share/heartbeat/.cache/ms-playwright/chromium-907428/chrome-linux/chrome --disable-background-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-background-pages --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose --allow-pre-commit-input --disable-hang-monitor --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-backgrounding --disable-sync --force-color-profile=srgb --metrics-recording-only --no-first-run --enable-automation --password-store=basic --use-mock-keychain --no-service-autorun --user-data-dir=/tmp/playwright_chromiumdev_profile-vWKBgW --remote-debugging-pipe --no-sandbox --no-startup-window
  <launched> pid=244
  [pid=244][err] [244:244:0119/160156.284241:ERROR:browser_main_loop.cc(1400)] Unable to open X display.
  ============================================================
      at Function.setupDriver (/usr/share/heartbeat/.node/node/lib/node_modules/@elastic/synthetics/src/core/gatherer.ts:48:43)
      at Function.createContext (/usr/share/heartbeat/.node/node/lib/node_modules/@elastic/synthetics/src/core/runner.ts:157:35)
      at Runner.runJourney (/usr/share/heartbeat/.node/node/lib/node_modules/@elastic/synthetics/src/core/runner.ts:410:34)
      at Runner.run (/usr/share/heartbeat/.node/node/lib/node_modules/@elastic/synthetics/src/core/runner.ts:488:22)
      at Object.run (/usr/share/heartbeat/.node/node/lib/node_modules/@elastic/synthetics/src/index.ts:45:12)
      at /usr/share/heartbeat/.node/node/lib/node_modules/@elastic/synthetics/src/cli.ts:201:19 {
    name: 'Error'
  }

It's also worth highlighting that we were also not able to run headful tests on the old Heartbeat image too. I tried running Headful tests within the 7.16 image and got the same error.
@vigneshshanmugam do you think that should be a supported case within the images? I feel like it's up to the user to install X and create the necessary display if they'd like to run headful tests, but I'm of course open to discussing it.
Also, if we do end-up supporting headful runs, that means we will not disable GPU acceleration, which may cause failures inside these containers, so we'd need to handle that better with libmesa or one of the alternatives we discussed earlier.

vigneshshanmugam · 2022-01-19T19:26:13Z

@lucasfcosta Thanks Lucas for testing it and providing the details.

In that website, all of the pieces of text rendered fine in the system's fallback font

Great.

do you think that should be a supported case within the images? I feel like it's up to the user to install X and create the necessary display if they'd like to run headful tests, but I'm of course open to discussing it.

Interesting, I didn't know the old image was not able to run headful tests. I am fine with any of the below options

Leave it up to the user to do the full setup.
We can add xvfb to the dependencies and let the user do the rest.

Also, if we do end-up supporting headful runs, that means we will not disable GPU acceleration, which may cause failures inside these containers, so we'd need to handle that better with libmesa or one of the alternatives we discussed earlier.

Gotcha, we should make a call here. Lets see what others have to say @andrewvc @paulb-elastic @drewpost

drewpost · 2022-01-20T10:45:32Z

@lucasfcosta Thanks Lucas for testing it and providing the details.

In that website, all of the pieces of text rendered fine in the system's fallback font

Great.

do you think that should be a supported case within the images? I feel like it's up to the user to install X and create the necessary display if they'd like to run headful tests, but I'm of course open to discussing it.

Interesting, I didn't know the old image was not able to run headful tests. I am fine with any of the below options

Leave it up to the user to do the full setup.

We can add xvfb to the dependencies and let the user do the rest.

Also, if we do end-up supporting headful runs, that means we will not disable GPU acceleration, which may cause failures inside these containers, so we'd need to handle that better with libmesa or one of the alternatives we discussed earlier.

Gotcha, we should make a call here. Lets see what others have to say @andrewvc @paulb-elastic @drewpost

My gut feel is that it's OK to disable GPU acceleration. We're not a device simulation testing product. What's key is to keep the results consistent and as long as we pick one option or the other and stick with it, then that requirement is met. There may be real world impact on the sizing we need to allow for given the more inefficient CPU only approach and I'm open to that as being something we discuss from an operation efficiency standpoint but from a product perspective, I'm OK with not enabling GPU acceleration. cc @lucasfcosta @vigneshshanmugam

mergify · 2022-01-25T02:00:55Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b install-fonts upstream/install-fonts
git merge upstream/master
git push upstream install-fonts

lucasfcosta · 2022-01-25T09:04:54Z

Hey @drewpost thanks a lot for your input! 😊 With regards to your last point about GPU acceleration I've recently run some tests within containers and it seems like containers do not have access to the underlying host's GPU so there's no actual difference in performance.

I've added a few more details in this link.

andrewvc · 2022-01-27T00:50:34Z

I've pushed a change to use google's SIL licensed noto fonts. All the tests listed previously still work, with all languages rendering.

…iple languages [fix elastic#29495]

lucasfcosta · 2022-01-27T14:45:46Z

I have re-tested all the websites in this PR with the new fonts and they all worked fine, including Thai websites, which I hadn't checked before.

As long as everyone's happy with the chosen font's licenses, I think we can go ahead and merge this in. What do you think @andrewvc?

lucasfcosta · 2022-01-27T17:08:11Z

/test

andrewvc

LGTM

vigneshshanmugam · 2022-01-27T18:27:42Z

dev-tools/packaging/templates/docker/Dockerfile.elastic-agent.tmpl

        apt-get clean all && \
        exit_code=0 && break || exit_code=$? && echo "apt-get error: retry $iter in 10s" && sleep 10; \
    done; \
    (exit $exit_code)
+RUN apt install fonts-noto-cjk


Why do we explicitly install the fonts on elastic-agent image and not on the HB image?

ah, that's a bug, it's actually installed higher up, this is redundant

vigneshshanmugam

LGTM with pending comment #29861 (comment)

…tall-fonts

…languages (#29861) This PR fixes #29495 by adding more fonts to support multiple different characters from multiple languages. After upgrading the base image, even though all characters from a few languages worked fine, not all characters from all languages were being displayed. (cherry picked from commit 457b0bb)

andrewvc · 2022-01-28T16:26:02Z

@Mergifyio backport 7.17

…languages (#29861) This PR fixes #29495 by adding more fonts to support multiple different characters from multiple languages. After upgrading the base image, even though all characters from a few languages worked fine, not all characters from all languages were being displayed. (cherry picked from commit 457b0bb)

mergify · 2022-01-28T16:26:54Z

backport 7.17

✅ Backports have been created

#30093 Add fonts to support more different types of characters for multiple languages (backport #29861) has been created for branch 7.17

…languages (#29861) (#30091) This PR fixes #29495 by adding more fonts to support multiple different characters from multiple languages. After upgrading the base image, even though all characters from a few languages worked fine, not all characters from all languages were being displayed. (cherry picked from commit 457b0bb) Co-authored-by: Lucas F. da Costa <[email protected]>

…languages (#29861) (#30093) This PR fixes #29495 by adding more fonts to support multiple different characters from multiple languages. After upgrading the base image, even though all characters from a few languages worked fine, not all characters from all languages were being displayed. (cherry picked from commit 457b0bb) Co-authored-by: Lucas F. da Costa <[email protected]>

…k-version-after-8-0-creation * upstream/master: (69 commits) Update stale config following (elastic#30082) Make include_matches backwards compatible with 7.x config (elastic#30032) [Filebeat] Update handling of elasticsearch server logs (elastic#30018) Remove SSL3 support from libbeat and its documentation. (elastic#30071) Revert "Packaging: rename arm64 suffix to aarch64 in the tar.gz artifacts ONLY (elastic#28813)" (elastic#30083) [libbeat] Add script processor to all beats (elastic#29752) Add fonts to support more different types of characters for multiple languages (elastic#29861) libbeat/reader: Fix messge conversion to beat.Event (elastic#30057) probot[stale]: ignore issues with the tag flaky-test (elastic#30065) [DOCS] Add redirect for GSuite module (elastic#30034) [Automation] Update elastic stack version to 8.1.0-aa69d697 for testing (elastic#30012) Remove msitools install for windows build, using the latest docker image with msitools preinstalled (elastic#30040) filebeat/generator/fields: fix dropped error (elastic#29943) Include the error message with auditd module events (elastic#30009) [Metricbeat] gcp: add firestore metricset (elastic#29918) probot: update stale dates (elastic#29997) Metricbeat enterprise search module: add xpack.enabled support (elastic#29871) x-pack/packetbeat: install Npcap at start-up when required (elastic#29112) [Filebeat] Fix panic in decode_cef when recovering from invalid data (elastic#30038) Correctly fixe how selected packages are defined (elastic#30039) ...

fix: add fonts to support more different types of characters for mult…

0291176

…iple languages [fix elastic#29495]

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 14, 2022

mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 14, 2022

lucasfcosta added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label Jan 14, 2022

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 14, 2022

lucasfcosta added backport backport-v8.0.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify labels Jan 14, 2022

mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Jan 14, 2022

lucasfcosta requested a review from andrewvc January 14, 2022 16:53

lucasfcosta marked this pull request as ready for review January 14, 2022 16:53

lucasfcosta requested a review from a team as a code owner January 14, 2022 16:53

vigneshshanmugam reviewed Jan 14, 2022

View reviewed changes

andrewvc approved these changes Jan 15, 2022

View reviewed changes

lucasfcosta force-pushed the install-fonts branch from 0291176 to d4c483e Compare January 15, 2022 11:00

lucasfcosta marked this pull request as draft January 15, 2022 11:05

fix: add fonts to support more different types of characters for mult…

377ab26

…iple languages [fix elastic#29495]

lucasfcosta force-pushed the install-fonts branch from d4c483e to 377ab26 Compare January 17, 2022 08:57

andrewvc added 2 commits January 26, 2022 18:48

Prefer noto fonts

ea0dcfe

Merge remote-tracking branch 'lucas/install-fonts' into install-fonts

6ee5938

lucasfcosta marked this pull request as ready for review January 27, 2022 09:25

lucasfcosta added 2 commits January 27, 2022 11:57

fix: add fonts to support more different types of characters for mult…

10096cb

…iple languages [fix elastic#29495]

fix: add fonts to support more different types of characters for mult…

644a0fc

…iple languages [fix elastic#29495]

lucasfcosta force-pushed the install-fonts branch from 6ee5938 to 1428809 Compare January 27, 2022 11:58

andrewvc approved these changes Jan 27, 2022

View reviewed changes

Prefer noto fonts

1518c19

lucasfcosta force-pushed the install-fonts branch from 1428809 to 1518c19 Compare January 27, 2022 17:12

vigneshshanmugam reviewed Jan 27, 2022

View reviewed changes

vigneshshanmugam approved these changes Jan 27, 2022

View reviewed changes

andrewvc added 3 commits January 27, 2022 16:00

Remove redundant font install

44327ff

Merge branch 'install-fonts' of github.com:lucasfcosta/beats into ins…

f1c91ff

…tall-fonts

Remove redundant font install

668449d

lucasfcosta force-pushed the install-fonts branch from 72e27aa to 668449d Compare January 28, 2022 09:09

andrewvc merged commit 457b0bb into elastic:master Jan 28, 2022

mergify bot mentioned this pull request Jan 28, 2022

[8.0](backport #29861) Add fonts to support more different types of characters for multiple languages #30091

Merged

lucasfcosta deleted the install-fonts branch January 28, 2022 16:07

mergify bot mentioned this pull request Jan 28, 2022

[7.17] Add fonts to support more different types of characters for multiple languages (backport #29861) #30093

Merged

andrewvc added v7.17.0 v8.0.0 labels Jan 28, 2022

lucasfcosta mentioned this pull request Jan 31, 2022

[Heartbeat] Move changelog entries from breaking to bug #30113

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add fonts to support more different types of characters for multiple languages #29861

Add fonts to support more different types of characters for multiple languages #29861

lucasfcosta commented Jan 14, 2022 •

edited

Loading

mergify bot commented Jan 14, 2022

andrewvc commented Jan 14, 2022

elasticmachine commented Jan 14, 2022

elasticmachine commented Jan 14, 2022 •

edited by jenkins-beats-ci bot

Loading

Build stats

Test stats 🧪

vigneshshanmugam Jan 14, 2022

lucasfcosta Jan 15, 2022

andrewvc commented Jan 14, 2022

andrewvc left a comment

lucasfcosta commented Jan 19, 2022

vigneshshanmugam commented Jan 19, 2022

drewpost commented Jan 20, 2022

mergify bot commented Jan 25, 2022

lucasfcosta commented Jan 25, 2022

andrewvc commented Jan 27, 2022

lucasfcosta commented Jan 27, 2022

lucasfcosta commented Jan 27, 2022

andrewvc left a comment

vigneshshanmugam Jan 27, 2022

andrewvc Jan 27, 2022

vigneshshanmugam left a comment •

edited

Loading

andrewvc commented Jan 28, 2022

mergify bot commented Jan 28, 2022

Add fonts to support more different types of characters for multiple languages #29861

Add fonts to support more different types of characters for multiple languages #29861

Conversation

lucasfcosta commented Jan 14, 2022 • edited Loading

What does this PR do?

Why is it important?

Checklist

Author's Checklist

How to test this PR locally

For Heartbeat

For Elastic Agent

Related issues

Screenshots

mergify bot commented Jan 14, 2022

andrewvc commented Jan 14, 2022

elasticmachine commented Jan 14, 2022

elasticmachine commented Jan 14, 2022 • edited by jenkins-beats-ci bot Loading

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

vigneshshanmugam Jan 14, 2022

Choose a reason for hiding this comment

lucasfcosta Jan 15, 2022

Choose a reason for hiding this comment

andrewvc commented Jan 14, 2022

andrewvc left a comment

Choose a reason for hiding this comment

lucasfcosta commented Jan 19, 2022

vigneshshanmugam commented Jan 19, 2022

drewpost commented Jan 20, 2022

mergify bot commented Jan 25, 2022

lucasfcosta commented Jan 25, 2022

andrewvc commented Jan 27, 2022

lucasfcosta commented Jan 27, 2022

lucasfcosta commented Jan 27, 2022

andrewvc left a comment

Choose a reason for hiding this comment

vigneshshanmugam Jan 27, 2022

Choose a reason for hiding this comment

andrewvc Jan 27, 2022

Choose a reason for hiding this comment

vigneshshanmugam left a comment • edited Loading

Choose a reason for hiding this comment

andrewvc commented Jan 28, 2022

mergify bot commented Jan 28, 2022

✅ Backports have been created

lucasfcosta commented Jan 14, 2022 •

edited

Loading

elasticmachine commented Jan 14, 2022 •

edited by jenkins-beats-ci bot

Loading

vigneshshanmugam left a comment •

edited

Loading